[ONNX] Add MatMul for FBC/BC #3657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-churkin
force-pushed
the
ac/matmul_fbc_onnx
branch
from
fbec013 to
c7c68ff
Compare
andrey-churkin
force-pushed
the
ac/matmul_fbc_onnx
branch
from
1f0d75c to
66ef2c4
Compare
andrey-churkin
commented
Oct 15, 2025
| op_names = ["MatMul"] | ||
| hw_config_names = [HWConfigOpName.MATMUL] | ||
| weight_channel_axis = -1 # For port_id=1 | ||
| bias_port_id = 2 |
Contributor
Author
There was a problem hiding this comment.
This does not apply to the MatMul ONNX operation, as it does not accept a bias input. Reference: https://onnx.ai/onnx/operators/onnx__MatMul.html
andrey-churkin
commented
Oct 15, 2025
Comment on lines
-178
to
-181
| if bias_value.ndim > 1: | ||
| # Make index positive | ||
| output_channel_axis = range(bias_value.ndim)[output_channel_axis] | ||
| input_channel_axis = range(bias_value.ndim)[input_channel_axis] |
Contributor
Author
There was a problem hiding this comment.
It was moved into create_input_data() because this method does not work properly with a negative channel_axis. The output_channel_axis is converted to positive inside mean_per_channel() method.
Collaborator
nikita-savelyevv
left a comment
nikita-savelyevv
left a comment
There was a problem hiding this comment.
I've run FBC on a couple of ONNX models and I see that the number of constants that FBC is applied to for ONNX and OpenVINO cases differs significantly with the numbers being higher for ONNX backend. Is this expected?
nikita-savelyevv
approved these changes
Oct 23, 2025
andrey-churkin
force-pushed
the
ac/matmul_fbc_onnx
branch
from
e9f7ddb to
babda33
Compare
Contributor
Author
|
Build post_training_quantization # 740 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add support for the
MatMuloperation in the Fast Bias/Bias Correction algorithm.Reason for changes
The Fast Bias/Bias Correction algorithm is not applied to the
MatMul->Addsubgraph in which one of the inputs to the Add operation is a constant. In this case, theMatMuloperation is not considered as having a bias, so the algorithm is not applied.Related tickets
Ref: 135433
Tests